feat: add storybook to the framework list#1649
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThis pull request introduces Storybook as a listed framework within the application by adding a new entry to the SHOWCASED_FRAMEWORKS array in app/utils/frameworks.ts. The entry includes the framework name 'storybook', its corresponding package identifier 'storybook', and an associated oklch colour value. This change expands the public list of frameworks, allowing getFrameworkColor and isListedFramework to recognise Storybook as a supported framework. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/utils/frameworks.ts (1)
69-73: Colour format inconsistency: percentage vs decimal lightness.The new entry uses
67.88%for the lightness component, whilst the majority of existing entries use the decimal form (e.g.,0.6788). A handful of existing entries (nitro,next,tanstack start) already use the percentage form, so this is not introduced by this PR, but it is worth normalising across all entries to avoid confusion.♻️ Decimal normalisation for the new entry (consistent with the majority)
- color: 'oklch(67.88% 0.2222 5.18)', + color: 'oklch(0.6788 0.2222 5.18)',
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks for your first contribution, @JReinhold! ⭐ We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
2 participants
🔗 Linked issue
🧭 Context
📚 Description
Adds Storybook to the list of showcased frameworks.